regex reemplazar no funciona en IE

Okay, I've update this question with improved code from the answers and comments below and more similar to the real project. But still it's not working in IE8. violín aquí

<ul id="definitions">
    <li id="defid63">keyword1<input type="hidden" value="63" /></li>
    <li id="defid61">keyword2<input type="hidden" value="61" /></li>
    <li id="defid62">Keyword3<input type="hidden" value="62" /></li>
</ul>

<div id="html">Lorem ipsum keyword1 dolor keyword2 sit keyword3 amet, consectetur adipisicing elit, sed do eiusmod tempor</div>

I've a list (ul > li) of keywords and there is a string with some text. I would like to wrap each occurrence of a keyword with an <a>-tag. I've code which works fine in firefox and chrome, but IE(8) doesn't match the regex somehow.

jQuery(function($) {

    // created by Gracenotes
    // http://goo.gl/MTkcY
    RegExp.quote = function(str) {
        return str.replace(/([.?*+^$[\]\\(){}-])/g, "\\$1");
    };

    var $node = $('#html'),
        // the dom element
        html = $node.html(); // the text we'll manipulate

    $('#definitions li').each(function() {
        var defid = $(this).find('input').val(),
            deftext = $(this).html().split("<input")[0],
            //the keyword
            //pattern = eval('/\\b('+RegExp.quote(deftext)+')\\b/gi');
            pattern = new RegExp('\\b(' + RegExp.quote(deftext) + ')\\b', 'gi');
        html = html.replace(pattern, '<a href="#id=' + defid + '">$1</a>');
    });

    // replace the dom content with our updated text
    $node.html(html);

});

preguntado el 08 de noviembre de 11 a las 16:11

Que pasa con var pattern = new RegExp('\\b(' + def + ')\\b', 'gi'); ? Using "eval()" seems icky. -

You'd still be ahead to avoid eval()--not that special ops teams will descend through your ceiling and steal your keyboard or anything; but RegExp is the right tool for the job :) -

You're absolutely right and I won't do it again ;) -

3 Respuestas

Esto debería funcionar:

var pattern = new RegExp('\b('+def+')\b','gi');

passing variable to a regexp in javascript

contestado el 23 de mayo de 17 a las 14:05

Pretty sure you don't want the slashes when calling new RegExp en una cuerda. - Dan

hm, I tested it in fiddle with \\b and it works like a charm; what gives? - Kato

@Kato if you mean my comment, I was referring to the fact that mblase75's answer originally included forward slashes as for a RegExp literal, I wasn't addressing the question of number of backslashes in a cadena literal :) - Dan

@Dan aaaaaaaaaah :) So I wonder if \b works as opposed to \\b (runs of to fiddle) - Kato

Okay, the actual problem was lying inside the code which I didn't provide in the first version of my question. I used the code deftext = $(this).html().split("<input")[0], which doesn't work in IE8 because IE changes tags into uppercase characters. Browsers like FF and Chrome don't do that. So, using eval() to make an expression does work and wasn't really the problem: demo here jsfiddle.net/zluiten/79rhW - netiul

This works in IE 8; test it in this fiddle.

Esto es lo que hice:

  • replaced eval() with RegExp
  • escaped the reference text before using in regex
  • fudged an id since you didn't provide that code

Aqui esta el codigo

jQuery(function($) {

    // created by Gracenotes
    // http://goo.gl/MTkcY
    RegExp.quote = function(str) {
       return str.replace(/([.?*+^$[\]\\(){}-])/g, "\\$1");
    };

    var $node = $('#html'),   // the dom element
        html  = $node.html(); // the text we'll manipulate

    $('#definitions li').each(function() {
        var $this   = $(this),
            //I didn't know where defid came from
            //so I just added it as id attribute
            defid   = $this.attr('id'), 
            deftext = $(this).text(), //the keyword
            pattern = new RegExp('\\b(' + RegExp.quote(deftext) + ')\\b', 'gi');
        html = html.replace(pattern, '<a href="#id=' + defid + '">$1</a>');
    });

    // replace the dom content with our updated text
    $node.html(html);

});

respondido 08 nov., 11:20

Okay, the actual problem was lying inside the code which I didn't provide in the first version of my question. I used the code deftext = $(this).html().split("<input")[0], which doesn't work in IE8 because IE changes tags into uppercase characters. Browsers like FF and Chrome don't do that. So, using eval() to make an expression does work and wasn't really the problem: demo here jsfiddle.net/zluiten/79rhW - netiul

Okay, the actual problem was lying inside the code which I didn't provide in the first version of my question. I used the code deftext = $(this).html().split("<input")[0], which doesn't work in IE8 because IE changes tags into uppercase characters. Browsers like FF and Chrome don't do that. So, using eval() to make an expression does work and wasn't really the problem: demo here http://jsfiddle.net/zluiten/79rhW/

Respondido 03 Jul 14, 13:07

No es la respuesta que estás buscando? Examinar otras preguntas etiquetadas or haz tu propia pregunta.